[Table] Add table-footer-group CSS #11264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t49tran You need to run |
|
I completely miss that @mbrookes , will update it |
oliviertassinari
previously requested changes
May 7, 2018
| @@ -12,9 +20,9 @@ class TableFooter extends React.Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const { component: Component, ...other } = this.props; | |||
| const { classes, className: classNameProp, component: Component, ...other } = this.props; | |||
There was a problem hiding this comment.
I don't think that we need the intermediary classNameProp variable.
oliviertassinari
added
new feature
oliviertassinari
changed the title
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add classes prop to
TableFootercomponent and wrap it with the HOCwithStylesso the 3 table section componentTableHead,TableBodyandTableFooteris consistent as per discussion in #11182 (already closed).In this PR:
--- update TableFooter with classes and className props.
--- update TableFooter typing
--- update TableFooter test to test for root classes.